Template talk:Institution/layout

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

Update[edit]

{{editprotected}} Please add {{Ifcreator|collapsed}} after {{ifimage|collapsed}}. Thanks.  Docu  at 16:50, 24 October 2010 (UTC)[reply]

✓ Done --DieBuche (talk) 16:55, 24 October 2010 (UTC)[reply]

Update bis[edit]

{{editprotected}}


Please change

collapsible {{ifimage|collapsed}} {{Ifcreator|collapsed}}

to

{{#ifeq:{{NAMESPACE}}|Institution|collapsible|collapsed}}

This might solve the problem with [1]. --  Docu  at 19:25, 7 December 2010 (UTC)[reply]

Docu, I do not like your fix, it will collapse templates on Category pages. I think we should fix the original statement, which should have worked. May be you can

  1. copy current version of {{Creator}} and {{Creator/layout}} to {{Creator/test}} and {{Creator/layout-test}}
  2. modify one creator page to use {{Creator/test}}
  3. try to fix "collapsible {{ifimage|collapsed}} {{Ifcreator|collapsed}}" so it works in file and category namespaces and for your worklists.

Then ask to {{Editprotected}} --Jarekt (talk) 21:48, 8 December 2010 (UTC)[reply]

Actually I looked a little closer at output of [2] and none of the templates (creator or institution) can be collapsed. There is something wrong there. I also previewed {{institution:Louvre}} on the bottom of of one of the creator pages and it was collapsed. So I take it "collapsible {{ifimage|collapsed}} {{Ifcreator|collapsed}}" is working as designed. --Jarekt (talk) 21:56, 8 December 2010 (UTC)[reply]
Part of the problem might be that - even though, e.g., this appears to be in Creator namespace - it might not be applied when displaying the institution template. A workaround could be to change the default to collapsed.
{{#switch:{{NAMESPACE}}|Institution|Category=collapsible|collapsed}} could work for that. This is just a temporary fix for the current test version of the script. --  Docu  at 20:16, 9 December 2010 (UTC)[reply]

{{editprotected}} To summarize my previous comment: please change

collapsible {{ifimage|collapsed}} {{Ifcreator|collapsed}}

to

{{#switch:{{NAMESPACE}}|Institution|Category=collapsible|collapsed}}

Thanks. --  Docu  at 07:08, 11 December 2010 (UTC)[reply]

✓ Done the one above did not work right ( it was always uncollapsed). I think I fixed it now. --Jarekt (talk) 03:41, 12 December 2010 (UTC)[reply]
Indeed, "collapsible" needs to be a class at any time. and "collapsed" to show it collapsed. This class works because CSS hides the contents if it contains the "collapsed" class. The reason it is expanded by default is simple, becuase else when javascript (which makes the toggle-button) fails it can't be seen. So it's expanded by default unless "collapsed" is added by javascript-click or by template.
The reason it is expanded on the /work-pages is becuase the collapse-javascript only works for templates on the page during te initial load. Since this work-tool adds them a few seconds later via the toolserver, it script is already initialized and thus doesn't work.
This problem has come up in the past as well, I'll see if I can make a proper fix in the collapse-stuff. –Krinkletalk 17:33, 17 December 2010 (UTC)[reply]

Wrong Padding[edit]

{{editprotected}} Hi, please watch show button on this page, I think padding-right:3em; (on Museum name section) and must removed.−ebraminiotalk 14:35, 11 March 2011 (UTC)[reply]

From Commons (here) it doesn't look wrong because it's absolutely positioned, I guess that's why the padding was never noticed. ✓ FixedKrinkletalk 18:20, 12 March 2011 (UTC)[reply]
it is better to "padding-right: 0.5em;" removed entirely. Institution:Kunsthistorisches Museum have problem on collapsed mode that can fixed with removing "padding-right: 0.5em;" entirely. −ebraminiotalk 18:32, 12 March 2011 (UTC)[reply]
my patch for completely solving RTL problems and collapsed mode problem on this template
<!-- Museum name -->
<tr valign="top">
<th colspan="3" style="background-color:#e0e0ee; font-weight:bold; border:1px solid #aaa;">{{#if:{{{inventory|}}}{{{demo|<noinclude>1</noinclude>}}}|<span style="float:{{#ifeq:{{dir|{{{lang}}}}}|rtl|left|right}}; font-size:80%; margin-{{#ifeq:{{dir|{{{lang}}}}}|rtl|left|right}}:20px;"> ([[{{{inventory|Inventory Glyptothek Munich}}}|{{{inventory label|inventory}}}]])</span>}}<span class="fn">{{#ifexist:{{{name}}}|[[{{{name}}}]]|{{{name}}}}}</span>[[File:Icons-mini-icon link.gif|{{{linkback label|Link back to Museum infobox template}}}|link={{{linkback|}}}]]</th>
</tr>

ebraminiotalk 07:50, 14 March 2011 (UTC)[reply]

✓ Done --Màñü飆¹5 talk 23:36, 14 March 2011 (UTC)[reply]

Picture SVG version available[edit]

Just change png to svg in the name. Thanks. — Bjung (talk) 06:35, 25 June 2011 (UTC)[reply]

✓ Done --Jarekt (talk) 01:57, 29 June 2011 (UTC)[reply]

Wikidata link format[edit]

Instead of the small icon currently in use, I'd add a line for Wikidata in the format (sample for the test at Institution:Glyptothek Munich:

Wikidata Q162077

I'd add that below the institution's website. --  Docu  at 18:11, 31 December 2012 (UTC)[reply]

I think, I prefer the current layout since it parallels {{Creator}} layout and other wikisource/wikiquote links. Also the "Q162077" code is not that meaningful to most people so keeping it hidden makes template less cluttered and more readable. --Jarekt (talk) 14:52, 2 January 2013 (UTC)[reply]

Breaks table cells[edit]

There is something about the current layout which makes it break out of the table cell in which it is inserted. This becomes obvious when adding more than one institution table to e.g. the artwork template.

Example with two institutions displaying incorrectly[edit]

  • Nr 1:
institution QS:P195,Q131454
  • Nr 2:
institution QS:P195,Q131454

Example with two license templates displaying correctly[edit]

  • Nr 1:
    • Nr 2:

I am however unsure what exactly it is that breaks the expected behaviour. /André Costa (WMSE) (talk) 09:43, 4 August 2014 (UTC)[reply]

Currently the template contains a <table class="toccolours collapsible {{#switch:{{NAMESPACE}}|File|Creator=collapsed}}"> element. What do you think about adding a parameter to collapse the template also in Template:Category definition: Objects? The parameter would be used just once in that template. It should be a fine visual improvement for the 21667 transclusions of the template. Since I've yet opened a discussion at Template talk:Creator it will be the best to discuss the question there for both cases. Thanks, --Marsupium (talk) 21:07, 12 June 2015 (UTC)[reply]

{{Institution}} is an offshoot of {{Creator}} and has the same limitations. Both of the templates can be collapsed in specific namespaces and we do not want them collapsed in Category namespace. Where Template:Category definition: Object is often used. {{Institution}} and {{Creator}} are collapsed in File namespace. --Jarekt (talk) 22:47, 12 June 2015 (UTC)[reply]