Module talk:NationAndOccupation

local style

Can he lang (Hebrew) be add with "Occupation then nationality order". -- Geagea (talk) 04:47, 28 January 2018 (UTC)

Geagea, I see you added and than removed it. Should it be in or out? If the current version is not right, than let's make sure we fix it. --Jarekt (talk) 17:07, 28 January 2018 (UTC)

Jarekt, I added it but it does'nt work so I removed it. There are more to fix but first lets fix that. -- Geagea (talk) 17:16, 28 January 2018 (UTC)

Thanks Jarekt, now it worked. Also fixed gender issue for occupation. Were should I update the female gender for nationality?

And also, the use of the word "and" in hebrew "וגם". Actually it means "and also". In fact the correct would be using "ו" without a space with the word that comes next. Already update Template:And, but seems that does not taken from there. -- Geagea (talk) 20:27, 28 January 2018 (UTC)

As a matter of a fact the female version of nationality should be fixed. -- Geagea (talk) 21:39, 28 January 2018 (UTC)

Female version of nationality is done two ways:

1. old way using commons templates would have been done by Template:Nationality/he which should look a bit like Template:Nationality/pl
2. new way using Wikidata is done by adding female form of label (P2521). See how it is set in d:Q1028181

At the moment old way is used by templates that have local values for occupation and new way when occupation values come from Wikidata. I am planning to grab many of the translations from Commons and import them to Wikidata. --Jarekt (talk) 02:40, 29 January 2018 (UTC)

I already checked and the female gender label alredy updated to female form of label (P2521) in countries I have checked. Look like it doesn't work in nationality. It have to be fixed in Module:NationAndOccupation. -- Geagea (talk) 03:06, 29 January 2018 (UTC)

Can you give me an example page. Say what you see and what you would like to see. --Jarekt (talk) 04:08, 29 January 2018 (UTC)

Geagea, about "and": I do not know which process uses Template:And. Most use Module:Linguistic where I added Hebrew translation of "and". --Jarekt (talk) 04:08, 29 January 2018 (UTC)

Jarekt, I think it comes from her (in PL). Anyway there shouldn't be a space between "ו" and the next word. See this, should be "וציירת" and not "ו ציירת".

And the nationality that I have mentioned. "אמנית" (female artist) it's ok. "ציירת" (female painter) is ok. But "ישראלי" is Israeli for male, it should be "ישראלית". The female form of label (P2521) label "ישראלית" in Q801 already exist, so the problem probably is this Module for all the languages using male/female. -- Geagea (talk) 06:31, 29 January 2018 (UTC)

Well, in Arabic it's ok (AR), the template uses the female version. So why it is not working for Hebrew? -- Geagea (talk) 06:55, 29 January 2018 (UTC)

It seems space after Hebrew “ו” has been removed, could that be done for Arabic “و” as well? Displaying {{NationAndOccupation|wikidata=Q47457363|lang=ar}} as “إسرائيلية فنانة ورسامة”‎ instead of “إسرائيلية فنانة و رسامة”‎ (English translation: “Israeli artist and painter”). I don't find where you have fixed it for Hebrew … Thank you! --Marsupium (talk) 13:51, 21 October 2018 (UTC)

Marsupium, The fix was done by Geagea here. --Jarekt (talk) 02:33, 29 October 2018 (UTC)

Thank you, I've made an edit request there. --Marsupium (talk) 20:47, 29 October 2018 (UTC)

Jarekt, can you add bg lang on the line 81 (after pl and/or ru) so it could be stylized as special case for the first nationality and lowercase for the second? Thank you. --Ted Masters (talk) 20:27, 28 October 2018 (UTC)

 Done --Jarekt (talk) 02:35, 29 October 2018 (UTC)

Why is ethnicity/religion a subset of nationality?

I'm not sure if this is the best place to address the issue, but it's worth asking why racial/ethnicity/religion categories (e.g. "Jewish", "Iranian Arab", "Canadians of German ethnicity", "African American") are even present at Module:NationAndOccupation/nationalityLUT and callable from {{Nationality}}. For the purpose of neutral descriptors of people in most occupations, nationality and occupation is sufficient ("Russian photographer", "American writer"), and appending racial/ethnic labels like "American Jewish politician", or "African American architect" can have the effect of "marking", "othering" and/or "ghettoizing" the individual. To wit, the description in Creator:Al Franken previously read "American-American Jew politician" (which is both grammatically incorrect and irrelevant emphasis on religion) before I locally over-ruled it. I have no idea how many other templates may be similarly inappropriately worded, but some investigation might be in order. --Animalparty (talk) 01:13, 19 February 2019 (UTC)

@Animalparty: racial/ethnicity/religion categories should be removed from Module:NationAndOccupation/nationalityLUT and not callable from {{Nationality}}.   — Jeff G. ツ _{please ping or talk to me} 13:41, 19 February 2019 (UTC)

People using {{NationAndOccupation}} requested or created capability to create statements like {{NationAndOccupation|m|Jewish/US|writer}} -> "Jewish-American writer". I now disabled all places where wikidata items are linked to term "Jewish", so in case phrases like "Jewish-American" is desired, it will need to be entered by hand to Nationality field of {{Creator}} or {{NationAndOccupation}} template. Jeff G. and --Animalparty, do you think there are other "problematic" connections in Module:NationAndOccupation/nationalityLUT. --Jarekt (talk) 14:46, 19 February 2019 (UTC)

@Jarekt: "Q12560 = 'ottomanottoman turkish', --Ottoman Empire" should probably use "TR" unless we have a country code for the Ottoman Empire.   — Jeff G. ツ _{please ping or talk to me} 15:24, 19 February 2019 (UTC)

Fixed According to {{Nationality}}, that template recognizes keyword "ottoman". --Jarekt (talk) 15:41, 19 February 2019 (UTC)

Support of male form of label (P3321)

Would maybe nice to use male form of label (P3321) as well. --Marsupium (talk) 18:59, 19 May 2019 (UTC)

Slashed nationalities from Wikidata aren't resolved

Jarekt, function harvest_wikidata() uses q2iso but doesn't split slashed values from Module:NationAndOccupation/nationalityLUT. Thus e.g. ethnic group (P172): Swedish Americans (Q115026) from Gunnar Widforss (Q5619161) ends up in an unsupported value: {{NationAndOccupation|wikidata=Q5619161}} → "American-Swedish painter and drawer". Thanks in advance for any fixes! --Marsupium (talk) 12:30, 20 May 2021 (UTC)

 Doing… I am working on it. --Jarekt (talk) 15:04, 21 May 2021 (UTC)

@Marsupium:  Done --Jarekt (talk) 03:10, 27 May 2021 (UTC)

@Jarekt: with the new version I got an error with the Template:Creator: "Lua error in Module:NationAndOccupation at line 108: frame:expandTemplate: invalid type table for arg '2'"--Le Petit Chat (talk) 08:29, 27 May 2021 (UTC)

Endash and nothing for apparently unsupported nationality

{{NationAndOccupation|wikidata=Q18529752}} currently gives "Slovene- photographer, painter and sculptor", maybe because there is Ivo Lorenčič (Q18529752) country of citizenship (P27): Socialist Federal Republic of Yugoslavia (Q83286) on Wikidata, but transformation support for Socialist Federal Republic of Yugoslavia (Q83286) here doesn't work. That can happen. But the "Slovene-" endash with nothing following seems to be a bad handling for this situation. Thanks in advance for any fixes! --Marsupium (talk) 09:15, 30 June 2022 (UTC)