MediaWiki talk:Gadget-AnonymousI18N.js/Archive/2020
This is an archive of past discussions. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
Allow specific pages to disable this script
The Structured Data Team at WMF is developing a new MediaSearch special page for Commons, and this script breaks one of the features we're in the process of implementing (more details here: https://phabricator.wikimedia.org/T260203).
I'd like to introduce a way to disable this script on specific pages (really, just one Special Page for the time being). Any opinions on the best way to do that? Currently the script checks if the current skin is something other than Vector and bails early if so. We could do something similar in terms of checking for a specific config variable, or even a hard-coded list, though a config var is probably better. Thoughts? –EGardner (WMF) (talk) 18:43, 12 August 2020 (UTC)
- @EGardner (WMF): What kind of config variable do you think of? Extension code should not depend on on-wiki script code IMO, so I would consider setting something like
AnonymousI18NSkip
in MediaSearch a quite hackish solution. https://gerrit.wikimedia.org/r/619838 seems to be a much cleaner solution. —Tacsipacsi (talk) 12:24, 13 August 2020 (UTC) - @Tacsipacsi: Yes, you're right about event delegation being a better solution here; I was thinking out loud here before I realized this was a viable workaround. This patch has just been merged, so I think the problem should be solved now. –EGardner (WMF) (talk) 19:08, 13 August 2020 (UTC)
Add vector-menu-portal class
The CSS for this is broken, as the relevant selectors seem to have been changed. To fix this, please change (on line 343) the text portal persistent
to portal vector-menu-portal persistent
--Yair rand (talk) 21:25, 26 August 2020 (UTC)