Module talk:POTY/parser

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

@Be..anyone: which problem did you try to address with this change? The hard-coded titles are mainly there for debugging purposes and only used if no title could be guessed or was supplied to the functions in concern; so I would be surprised if these changes changed something. Feel free to make useful changes, like careful coding and a code that confuses less people (e.g. adding comments), though. -- Rillke(q?) 10:42, 18 January 2015 (UTC)[reply]

No problem at all, or rather, I'm editing Commons talk:Picture of the Year/2014 to state that the church is now in the correct gallery, and wanted to figure out who should get the thanks. And stumbled over three suspicious easy to fix 2013, but then I saw that another user already tried that AND reverted the attempt. w:WP:BROKE, –Be..anyone (talk) 10:46, 18 January 2015 (UTC)[reply]
Glad to know there is no "issue" at all. We categorize using Commons:Picture_of_the_Year/2014/Candidates which is then parsed. -- Rillke(q?) 16:09, 18 January 2015 (UTC)[reply]

Edit request: fix errors

[edit]

{{Edit protected}}

I've made a couple edits in Module:POTY/parser/sandbox to fix the errors that are showing up on lots of POTY pages—declaring variables and using the correct escape character. Please implement these! —CalendulaAsteraceae (talkcontribs) 04:30, 29 February 2024 (UTC)[reply]

@CalendulaAsteraceae: Thanks, the changes look mostly good to me – but can you tell me why the colons in the patterns need to be escaped at all (whether with \ or %)? I don’t see any mention of : being a special character in mw:Extension:Scribunto/Lua reference manual#Patterns. Lucas Werkmeister (talk) 21:26, 29 February 2024 (UTC)[reply]
@Lucas Werkmeister: I have no idea (and didn't write that code); it's probably fine to take out the escape. —CalendulaAsteraceae (talkcontribs) 04:51, 1 March 2024 (UTC)[reply]
✓ Done, and at least Main Page/POTY2013 no longer shows an error now --Lucas Werkmeister (talk) 09:12, 1 March 2024 (UTC)[reply]
@Lucas Werkmeister: Thank you! I probably should have checked Module:POTY, because it's now also throwing errors. Fix is in Module:POTY/sandbox. —CalendulaAsteraceae (talkcontribs) 16:57, 1 March 2024 (UTC)[reply]
@CalendulaAsteraceae: I’m afraid I don’t have permission to edit Module:POTY; please file a new edit request on its talk page. Lucas Werkmeister (talk) 17:56, 1 March 2024 (UTC)[reply]
Will do, and thank you for your help! —CalendulaAsteraceae (talkcontribs) 19:22, 1 March 2024 (UTC)[reply]