MediaWiki talk:Gadget-contribsrange.js

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

ucfrm.namespace is undefined[edit]

ucfrm.namespace is undefined https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-contribsrange.js&action=raw&ctype=text/javascript&45534921 Line 41

Probably (I guess) due to the removed feature as discussed here Commons:Village_pump#Filtering_user_contribs_by_namespace. --Saibo (Δ) 15:30, 5 October 2011 (UTC)[reply]

https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-contribsrange.js&diff=60594464&oldid=45534921 works for me. Thank you, TheDJ. --Saibo (Δ) 17:35, 5 October 2011 (UTC)[reply]

Bad requests[edit]

{{Editprotected}} On https://pt.wikipedia.org/w/index.php?title=Especial%3AContribui%C3%A7%C3%B5es&contribs=user&target=186.215.21.* the script causes the following error

and on w:pt:Especial:Contribuições/186.215.21.* I get this error:

Helder 13:56, 22 October 2012 (UTC)

This is fixed in the new version I made available on test.wikipedia.org. That version also fixes the spinner, and update some deprecated functions. Could someone update this version of the gadget? It is also necessary to change the definition to

* contribsrange[ResourceLoader|dependencies=mediawiki.util,jquery.spinner]|contribsrange.js

For more details, see w:MediaWiki talk:Gadget-contribsrange.js#Protected edit request on 28 February 2014. Helder.wiki 19:28, 12 March 2014 (UTC)
I don't have time for a code review, that's why I've simply done what you requested to do. Thanks for your efforts. Maybe combine multiple var statements or, for the config, create a config-object-literal. -- Rillke(q?) 21:06, 14 March 2014 (UTC)[reply]

wgServer[edit]

Is there any reason to remove wgServer? Won't that cause the problem described on bugzilla:34036 when someone updates this scripts to use mw.loader.load instead of the (deprecated) importScriptURI? Helder 14:21, 22 October 2012 (UTC)

True. But the change was in 2011 and this bug dates back to 2012. So maybe not known issue to the person who amended the code. -- Rillke(q?) 21:08, 14 March 2014 (UTC)[reply]