MediaWiki talk:Gadget-QICvote.js

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search


Minor bug fix[edit]

{{Edit request}} On line 378, .trim() should be added to the element query: 

if ($(this).find(NOMINATION_CONTAINER).find("ul:first li:last i").text().trim() !== "Review needed")

Alternatively, a space can be added to the string on the RHS of the inequality, but it's essentially duct tape to sticky tape in terms of foolproofness.

There's probably some other things in this script worth addressing, but nothing too major. (Some stray debug console.logs, somewhat weird styling for the bottom toolbar, and so on.) Probably not worth making an edit request for, but I figure it's worth mentioning. Perryprog (talk) 21:36, 21 February 2021 (UTC)[reply]

✓ Done (added trim and removed console.log; no styling changes) --Lucas Werkmeister (talk) 19:36, 22 February 2021 (UTC)[reply]

New QICvote version[edit]

I have been working on a new version of the gadget to facilitate the review of images in the QIC section, some improvements include:

  • Improved user interface, now it is possible to see a cleaner bar and a more modern revision message.
  • Several validations were added, among them, it is no longer possible to leave a revision blank and if the user clicks on cancel, the entire process is canceled (previously it added a blank comment).

All was allready tested by QIC users.

Edit request[edit]

{{Edit request}}

  1. Create the file MediaWiki:Gadget-QICvote.css with the User:Wilfredor/QICvote.css content
  2. Copy the content from User:Wilfredor/QICvote.js to MediaWiki:Gadget-QICvote.js
  3. MediaWiki:Gadget-QICvote.js on line 11, 'User:Wilfredor/QICvote.css' should be replace by 'MediaWiki:Gadget-QICvote.css' in the load url (line 11):
mw.loader.load( '/w/index.php?title=MediaWiki:Gadget-QICvote.css&action=raw&ctype=text/css', 'text/css' );

Finally, add the new documentation help page (Help:Gadget-QICvote) to the gadget here: Mediaiki:Gadget-QICvote

I'm main author of the original script too --Wilfredor (talk) 19:14, 27 March 2021 (UTC)[reply]

@Wilfredor: ✓ Done Please test the script again and ensure that it is working as expected. AntiCompositeNumber (talk) 02:40, 31 March 2021 (UTC)[reply]
@AntiCompositeNumber: Please add the [documentation] link to the Help:Gadget-QICvote on Preferences->Gadgets Wilfredor (talk) 03:23, 31 March 2021 (UTC)[reply]
@Wilfredor: ✓ Done AntiCompositeNumber (talk) 04:02, 1 April 2021 (UTC)[reply]

{{Edit request}} Because a in production error, please rollback just the JS file to have more time to check what's happening --Wilfredor (talk) 03:01, 2 April 2021 (UTC)[reply]

✓ Done AntiCompositeNumber (talk) 03:03, 2 April 2021 (UTC)[reply]

{{Edit request}} @AntiCompositeNumber: Please copy from User:Wilfredor/temp.js to MediaWiki:Gadget-QICvote.js. Thanks --Wilfredor (talk) 03:22, 2 April 2021 (UTC)[reply]

✓ Done AntiCompositeNumber (talk) 03:31, 2 April 2021 (UTC)[reply]

{{Edit request}} @AntiCompositeNumber: Please copy from User:Wilfredor/temp.js to MediaWiki:Gadget-QICvote.js, and from User:Wilfredor/Gadget definition:Gadget-QICvote to Gadget definition:Gadget-QICvote. Thanks --Wilfredor (talk) 03:49, 2 April 2021 (UTC)[reply]

 Not done The Gadget definition namespace is not in use on Commons (or any Wikimedia wiki). See phab:T31272. Hard dependencies can be specified in MediaWiki:Gadgets-definition#SubprojectGadgets instead. --AntiCompositeNumber (talk) 22:37, 3 April 2021 (UTC)[reply]

{{Edit request}} MediaWiki:Gadget-QICvote.js on line 196, [[MediaWiki:Gadget-QICvote.js|QICvote]] should be replace by [[Help:Gadget-QICvote|QICvote]] in the summary url (line 196): 

summary: "Reviewing " + reviewCount + " nomination(s) with [[Help:Gadget-QICvote|QICvote]]",

Thanks --Wilfredor (talk) 16:52, 4 April 2021 (UTC)[reply]

✓ Done --Lucas Werkmeister (talk) 11:13, 5 April 2021 (UTC)[reply]

Bug report[edit]

Bug: Comment changes Promotion to Nomination[edit]

  • QICVote incorrectly sets the status of /Promotion back to /Nomination on "Comment". As per the QIC Guidelines "How to review", an image in /Promotion can move only to /Discuss, not to any other state. "Comment" should simply add the comment without changing the state. --Tagooty (talk) 09:28, 1 May 2021 (UTC)[reply]
  • Had the same incorrect action happen as Tagooty describes above. When you comment after a support vote has been received, the QICVoter app turns the nomination status back to Nominate (blue). I added a comment as the issues were fixable and I was not prepared to vote against the nomination at this time. --GRDN711 (talk) 19:06, 12 May 2022 (UTC)[reply]

Flickering[edit]

The current version is flickering if used at a smartphone. While it's flickering you can't type a comment. (It look like a switch of the focus of the input element.) --XRay 💬 04:23, 12 May 2021 (UTC)[reply]

Bug report: Preselect Promotion[edit]

The current version preselects "Promotion" for all images rather than showing the empty bar. Turned gadget on/off with no change. Any ideas? --Axel (talk) 20:44, 21 June 2021 (UTC)[reply]

Overwritten edit[edit]

Apparently an edit was published between I clicked publish reviews and when they were actually published, there was published another edit, which was overwritten [1]. --C messier (talk) 10:28, 7 November 2021 (UTC)[reply]

"This already a QI!"[edit]

{{Edit request}} Change This already a QI! to This is already a QI! 多多123 15:05, 8 July 2023 (UTC)[reply]

@多多123 Where is this text that needs to be changed? I can’t find it anywhere. Lucas Werkmeister (talk) 19:13, 8 July 2023 (UTC)[reply]
I don't know, I'm no developer. 多多123 22:47, 10 July 2023 (UTC)[reply]
@多多123 and Lucas Werkmeister: I think this is in MediaWiki:Gadget-QInominator.js - which is a separate gadget/script. But it says "This already is a QI!" there, which should be fine? Thanks. Mike Peel (talk) 21:15, 12 July 2023 (UTC)[reply]
That would explain why I couldn’t find This already a QI! anywhere. This already is a QI sounds a tad more awkward to me than This is already a QI, so I wouldn’t mind still changing it… what do you think? Lucas Werkmeister (talk) 23:29, 12 July 2023 (UTC)[reply]
@Lucas Werkmeister: This is is more commonly used, otherwise it looks as if it was translated into English from a foreign language, e.g. Esto ya es un QI or Questo già è un QI. 多多123 14:35, 13 July 2023 (UTC)[reply]

Gadget broken[edit]

The gadget currently isn't working, see Commons_talk:Quality_images_candidates#QI_Vote_stopped_working. Posted to Phab at phab:T341736 in case it's an issue on the MediaWiki side. @Lucas Werkmeister and Wilfredor: have also added you as subscribers in case you can help, hope that's OK. Thanks. Mike Peel (talk) 21:17, 12 July 2023 (UTC)[reply]

I made a quick edit (Special:Diff/782872580) based on the pattern in,
https://www.mediawiki.org/w/index.php?title=Snippets%2FDirect_imagelinks_to_Commons&type=revision&diff=5451422&oldid=3976429
But I'll take the time to give the gadget a more thorough reading. Please let me know if it helps. ABreault (WMF) (talk) 23:03, 12 July 2023 (UTC)[reply]
Per Special:Diff/782874904, that seems to have done the trick. For anybody watching, please note that a change was made earlier this week to how media is rendered by MediaWiki's parser, which, given the nature of commonswiki, might have an outsized effect here. If you notice any other breakage, don't hesitate to ping me.
And see mw:Parsoid/Parser_Unification/Media_structure/FAQ ABreault (WMF) (talk) 23:40, 12 July 2023 (UTC)[reply]

Broking again[edit]

Only for me, I test with an alternate account and is working fine, any idea?, I just delete all my config files and didn't work Ezarateesteban 19:01, 11 September 2023 (UTC)[reply]

QICvote is reverting edits[edit]

Hi ABreault (WMF) Please check Special:Diff/801648247. I never meant to revert User:Laquearius' edit in line 822. Cheers MB-one (talk) 19:43, 14 September 2023 (UTC)[reply]

That's ok, it was an edit conflict that was restored in Special:Diff/801653800 ABreault (WMF) (talk) 22:47, 15 September 2023 (UTC)[reply]

Vote applied to different image[edit]

QICvote applies my comment on a different image than the one I reviewed. This is the edit broken by QICvote. And here is the fix I had to make manually. This is consistent. While reviewing the same picture, I have encountered the same problem twice already in the morning. -- Jakubhal 15:53, 18 January 2024 (UTC)[reply]

Retrieved from "https://commons.wikimedia.org/w/index.php?title=MediaWiki_talk:Gadget-QICvote.js&oldid=843220739"