Commons:User scripts/users namespace/reports/User:VanWiel/monobook.js

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

This is the report page for User:VanWiel/monobook.js. It is bot-maintained. All manual changes might be overwritten.

jshint[edit]

  1. ISSUE: line 56 character 69: Use '===' to compare with 'null'. - Evidence: if ( wgNamespaceNumber != -1 || wgTitle != "Upload" || wgUserName == null) return ;
  2. ISSUE: line 60 character 10: Use '===' to compare with 'null'. - Evidence: if (ip == null) return;
  3. ISSUE: line 79 character 13: Use '===' to compare with 'null'. - Evidence: if (label == null)
  4. ISSUE: line 119 character 13: Use '!==' to compare with 'null'. - Evidence: if (input != null) hotcat_ok ();
  5. ISSUE: line 125 character 19: eval can be harmful. - Evidence: do_submit = eval (hotcat_old_onsubmit);
  6. ISSUE: line 138 character 12: Use '===' to compare with ''. - Evidence: if ( t == "" || t == "(+)" ) continue ;
  7. ISSUE: line 152 character 52: Use '!==' to compare with 'null'. - Evidence: if( document.getElementById('ca-viewsource' ) != null // User has no permission to edit
  8. ISSUE: line 166 character 20: Use '===' to compare with 'null'. - Evidence: if (visible_cats == null) {
  9. ISSUE: line 169 character 21: Use '===' to compare with 'null'. - Evidence: if (hidden_cats == null) {
  10. ISSUE: line 181 character 21: Use '===' to compare with 'null'. - Evidence: if (hidden_cats == null) {
  11. ISSUE: line 201 character 43: Use '!==' to compare with 'null'. - Evidence: && UploadForm.previous_hotcat_state != null)
  12. ISSUE: line 217 character 2: Missing semicolon. - Evidence: }
  13. ISSUE: line 252 character 51: Script URL. - Evidence: modify_link.href = "javascript:hotcat_modify(\"" + mod_id + "\");" ;
  14. ISSUE: line 354 character 26: The array literal notation [] is preferable. - Evidence: var result = new Array ();
  15. ISSUE: line 356 character 51: Use '!==' to compare with 'null'. - Evidence: while ((curr_match = cat_regex.exec (wikitext)) != null) {
  16. ISSUE: line 370 character 27: The array literal notation [] is preferable. - Evidence: var summary = new Array () ;
  17. ISSUE: line 380 character 14: Use '!==' to compare with 'null'. - Evidence: if (cat_rm != null && cat_rm.length > 0) {
  18. ISSUE: line 382 character 36: Use '===' to compare with '0'. - Evidence: if (!matches || matches.length == 0) {
  19. ISSUE: line 390 character 19: Use '!==' to compare with 'null'. - Evidence: if (cat_add != null && cat_add.length > 0 && matches[0].match.length > 1)
  20. ISSUE: line 413 character 15: Use '!==' to compare with 'null'. - Evidence: if (cat_add != null && cat_add.length > 0) {
  21. ISSUE: line 414 character 17: 'matches' is already defined. - Evidence: var matches = hotcat_find_category (t, cat_add);
  22. ISSUE: line 420 character 17: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
  23. ISSUE: line 420 character 19: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
  24. ISSUE: line 420 character 52: Use '!==' to compare with 'null'. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
  25. ISSUE: line 420 character 80: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
  26. ISSUE: line 420 character 82: Bad or unnecessary escaping. - Evidence: t = t + '\[\[Category:' + cat_add + (cat_key != null ? cat_key : "") + '\]\]\n';
  27. ISSUE: line 422 character 14: 't2' is already defined. - Evidence: var t2 = t.replace(hotcat_uncat_regex, ""); // Remove "uncat" templates
  28. ISSUE: line 456 character 45: Script URL. - Evidence: a_add.href = "javascript:hotcat_add_new()" ;
  29. ISSUE: line 494 character 13: Use '===' to compare with 'null'. - Evidence: if (label == null || !label.data) return defaultText;
  30. ISSUE: line 514 character 15: Use '!==' to compare with 'null'. - Evidence: if (l != null)
  31. ISSUE: line 521 character 15: Use '!==' to compare with 'null'. - Evidence: if (l != null)
  32. ISSUE: line 538 character 89: ['HotCatDelay'] is better written in dot notation. - Evidence: text.onkeyup = function () { window.setTimeout("hotcat_text_changed();", JSconfig.keys['HotCatDelay'] ); } ;
  33. ISSUE: line 538 character 38: Implied eval. Consider passing a function instead of a string. - Evidence: text.onkeyup = function () { window.setTimeout("hotcat_text_changed();", JSconfig.keys['HotCatDelay'] ); } ;
  34. ISSUE: line 557 character 12: Use '!==' to compare with 'null'. - Evidence: if (list != null) form.appendChild ( list ) ;
  35. ISSUE: line 559 character 14: Use '!==' to compare with 'null'. - Evidence: if (exists != null) form.appendChild ( exists ) ;
  36. ISSUE: line 571 character 10: Use '===' to compare with ''. - Evidence: if ( v == "" ) {
  37. ISSUE: line 639 character 14: Use '!==' to compare with 'null'. - Evidence: if (list != null) list.style.display = "none" ;
  38. ISSUE: line 641 character 16: Use '!==' to compare with 'null'. - Evidence: if (exists != null) exists.style.display = "none" ;
  39. ISSUE: line 648 character 10: Use '!==' to compare with ''. - Evidence: if ( v != "" ) {
  40. ISSUE: line 653 character 17: Use '===' to compare with 'null'. - Evidence: if (request == null) {
  41. ISSUE: line 656 character 16: 'list' is already defined. - Evidence: var list = document.getElementById ('hotcat_list');
  42. ISSUE: line 657 character 16: Use '!==' to compare with 'null'. - Evidence: if (list != null) list.style.display = "none" ;
  43. ISSUE: line 658 character 18: 'exists' is already defined. - Evidence: var exists = document.getElementById ('hotcat_exists');
  44. ISSUE: line 659 character 18: Use '!==' to compare with 'null'. - Evidence: if (exists != null) exists.style.display = "none" ;
  45. ISSUE: line 667 character 22: Use '===' to compare with 'null'. - Evidence: if ( xml == null ) return ;
  46. ISSUE: line 669 character 36: The array literal notation [] is preferable. - Evidence: var titles = new Array () ;
  47. ISSUE: line 686 character 41: The array literal notation [] is preferable. - Evidence: hotcat_show_suggestions ( new Array () ) ;
  48. ISSUE: line 697 character 12: Use '===' to compare with 'null'. - Evidence: if (list == null) return;
  49. ISSUE: line 700 character 14: Use '!==' to compare with 'null'. - Evidence: if (icon != null) icon.style.display = "none";
  50. ISSUE: line 703 character 22: Use '===' to compare with '0'. - Evidence: if ( titles.length == 0 ) {
  51. ISSUE: line 703 character 22: Too many errors. (83% scanned). - Evidence: undefined