Commons:User scripts/users namespace/reports/User:ישראל קרול/monobook.js

This is the report page for User:ישראל קרול/monobook.js. It is bot-maintained. All manual changes might be overwritten.

jshint

1. ISSUE: line 4 character 5: document.write can be a form of eval. - Evidence: document.write('<style type=\"text/css\">/*<![CDATA[*/@import \"/w/index.php?title=User:Eran/monobook.css/RTLlight.css&action=raw&ctype=text/css\";/*]]>*/</style>');
2. ISSUE: line 7 character 50: Use '!==' to compare with 'null'. - Evidence: if(document.getElementById('column-content')!=null) document.getElementById('column-content').style.direction='rtl';
3. ISSUE: line 40 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_remove_upload ( text ) {
4. ISSUE: line 52 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_check_upload () {
5. ISSUE: line 54 character 88: Use '===' to compare with 'null'. - Evidence: if ( wgNamespaceNumber != -1 || wgCanonicalSpecialPageName != "Upload" || wgUserName == null) return ;
6. ISSUE: line 58 character 10: Use '===' to compare with 'null'. - Evidence: if (ip == null) return;
7. ISSUE: line 82 character 13: Use '===' to compare with 'null'. - Evidence: if (label == null)
8. ISSUE: line 119 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_on_upload () {
9. ISSUE: line 122 character 13: Use '!==' to compare with 'null'. - Evidence: if (input != null) hotcat_ok ();
10. ISSUE: line 128 character 19: eval can be harmful. - Evidence: do_submit = eval (hotcat_old_onsubmit);
11. ISSUE: line 141 character 21: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
12. ISSUE: line 141 character 23: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
13. ISSUE: line 141 character 43: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
14. ISSUE: line 141 character 45: Bad or unnecessary escaping. - Evidence: var new_cat = "\[\[Category:" + t + "\]\]" ;
15. ISSUE: line 148 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat () {
16. ISSUE: line 166 character 57: Expected a 'break' statement before 'case'. - Evidence: container = document.getElementById ('quickbar');
17. ISSUE: line 180 character 52: Use '!==' to compare with 'null'. - Evidence: return document.getElementById ('ca-edit') != null;
18. ISSUE: line 199 character 20: Use '===' to compare with 'null'. - Evidence: if (visible_cats == null) {
19. ISSUE: line 202 character 21: Use '===' to compare with 'null'. - Evidence: if (hidden_cats == null) {
20. ISSUE: line 214 character 21: Use '===' to compare with 'null'. - Evidence: if (hidden_cats == null) {
21. ISSUE: line 235 character 43: Use '!==' to compare with 'null'. - Evidence: && UploadForm.previous_hotcat_state != null)
22. ISSUE: line 239 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_append_add_span ( catline ) {
23. ISSUE: line 251 character 2: Missing semicolon. - Evidence: }
24. ISSUE: line 253 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_is_on_blacklist ( cat_title ) {
25. ISSUE: line 262 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_modify_span ( span , i ) {
26. ISSUE: line 283 character 31: Use '!==' to compare with '0'. - Evidence: if (href.indexOf (prefix) != 0) prefix = wgServer + prefix; // Fully expanded URL?
27. ISSUE: line 284 character 31: Use '===' to compare with '0'. - Evidence: if (href.indexOf (prefix) == 0) {
28. ISSUE: line 305 character 51: Script URL. - Evidence: modify_link.href = "javascript:hotcat_modify(\"" + mod_id + "\");" ;
29. ISSUE: line 312 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_modify_existing ( catline ) {
30. ISSUE: line 319 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_getEvt (evt) {
31. ISSUE: line 323 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_evt2node (evt) {
32. ISSUE: line 335 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_evtkeys (evt) {
33. ISSUE: line 351 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_killEvt (evt)
34. ISSUE: line 364 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_remove (evt) {
35. ISSUE: line 385 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcatGetParamValue(paramName, h) {
36. ISSUE: line 398 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_find_category (wikitext, category)
37. ISSUE: line 409 character 26: The array literal notation [] is preferable. - Evidence: var result = new Array ();
38. ISSUE: line 411 character 51: Use '!==' to compare with 'null'. - Evidence: while ((curr_match = cat_regex.exec (wikitext)) != null) {
39. ISSUE: line 422 character 1: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function hotcat_check_action () {
40. ISSUE: line 426 character 27: The array literal notation [] is preferable. - Evidence: var summary = new Array () ;
41. ISSUE: line 438 character 15: Use '!==' to compare with 'null'. - Evidence: if (cat_key != null) cat_key = '|' + cat_key;
42. ISSUE: line 439 character 14: Use '!==' to compare with 'null'. - Evidence: if (cat_rm != null && cat_rm.length > 0) {
43. ISSUE: line 441 character 36: Use '===' to compare with '0'. - Evidence: if (!matches || matches.length == 0) {
44. ISSUE: line 449 character 19: Use '!==' to compare with 'null'. - Evidence: if (cat_add != null && cat_add.length > 0 && matches[0].match.length > 1)
45. ISSUE: line 468 character 41: Bad or unnecessary escaping. - Evidence: summary.push ( "Removed category \[\[:Category:" + cat_rm + "|" + cat_rm + "\]\]" ) ;
46. ISSUE: line 468 character 43: Bad or unnecessary escaping. - Evidence: summary.push ( "Removed category \[\[:Category:" + cat_rm + "|" + cat_rm + "\]\]" ) ;
47. ISSUE: line 468 character 84: Bad or unnecessary escaping. - Evidence: summary.push ( "Removed category \[\[:Category:" + cat_rm + "|" + cat_rm + "\]\]" ) ;
48. ISSUE: line 468 character 86: Bad or unnecessary escaping. - Evidence: summary.push ( "Removed category \[\[:Category:" + cat_rm + "|" + cat_rm + "\]\]" ) ;
49. ISSUE: line 472 character 15: Use '!==' to compare with 'null'. - Evidence: if (cat_add != null && cat_add.length > 0) {
50. ISSUE: line 473 character 17: 'matches' is already defined. - Evidence: var matches = hotcat_find_category (t, cat_add);
51. ISSUE: line 473 character 17: Too many errors. (44% scanned). - Evidence: undefined