Commons:User scripts/reports/MediaWiki:UploadFormTest.js

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

This is the report page for MediaWiki:UploadFormTest.js. It is bot-maintained. All manual changes might be overwritten.

jshint[edit]

  1. ISSUE: line 29 character 55: ['UploadForm_newlayout'] is better written in dot notation. - Evidence: (typeof (JSconfig) == 'undefined' || JSconfig.keys['UploadForm_newlayout']) ? null : true;
  2. ISSUE: line 31 character 37: Bad or unnecessary escaping. - Evidence: var UploadForm_ownwork_author = "\[\[User:" + mw.config.get('wgUserName') + "|" + mw.config.get('wgUserName') + "\]\]";
  3. ISSUE: line 31 character 39: Bad or unnecessary escaping. - Evidence: var UploadForm_ownwork_author = "\[\[User:" + mw.config.get('wgUserName') + "|" + mw.config.get('wgUserName') + "\]\]";
  4. ISSUE: line 31 character 117: Bad or unnecessary escaping. - Evidence: var UploadForm_ownwork_author = "\[\[User:" + mw.config.get('wgUserName') + "|" + mw.config.get('wgUserName') + "\]\]";
  5. ISSUE: line 31 character 119: Bad or unnecessary escaping. - Evidence: var UploadForm_ownwork_author = "\[\[User:" + mw.config.get('wgUserName') + "|" + mw.config.get('wgUserName') + "\]\]";
  6. ISSUE: line 92 character 14: Use '===' to compare with 'null'. - Evidence: if (rows == null) return minimum;
  7. ISSUE: line 143 character 24: Use '===' to compare with 'null'. - Evidence: if (wgUserLanguage == null || wgUserLanguage.length == 0) return;
  8. ISSUE: line 143 character 57: Use '===' to compare with '0'. - Evidence: if (wgUserLanguage == null || wgUserLanguage.length == 0) return;
  9. ISSUE: line 157 character 17: Use '===' to compare with '0'. - Evidence: if (i == 0)
  10. ISSUE: line 241 character 64: Bad or unnecessary escaping. - Evidence: 'Not your own file? Or already published elsewhere? Use \{\{OTRS pending\}\} and send permission by e-mail. '
  11. ISSUE: line 241 character 66: Bad or unnecessary escaping. - Evidence: 'Not your own file? Or already published elsewhere? Use \{\{OTRS pending\}\} and send permission by e-mail. '
  12. ISSUE: line 241 character 80: Bad or unnecessary escaping. - Evidence: 'Not your own file? Or already published elsewhere? Use \{\{OTRS pending\}\} and send permission by e-mail. '
  13. ISSUE: line 241 character 82: Bad or unnecessary escaping. - Evidence: 'Not your own file? Or already published elsewhere? Use \{\{OTRS pending\}\} and send permission by e-mail. '
  14. ISSUE: line 283 character 12: This character may get silently deleted by one or more browsers. - Evidence: ml: 'തര്‍ജ്ജമ',
  15. ISSUE: line 339 character 21: 'id' is already defined. - Evidence: for (var id in UFUI.defaultErrorMsgs) {
  16. ISSUE: line 343 character 21: 'id' is already defined. - Evidence: for (var id in UFUI.defaultHints) {
  17. ISSUE: line 453 character 44: Use '===' to compare with '0'. - Evidence: if (!close_imgs || close_imgs.length == 0)
  18. ISSUE: line 476 character 14: Use '!==' to compare with 'null'. - Evidence: if (fn != null) fn = fn.value;
  19. ISSUE: line 477 character 14: Use '!==' to compare with 'null'. - Evidence: if (fn != null) {
  20. ISSUE: line 491 character 34: Use '!==' to compare with 'null'. - Evidence: add_plea = (help_main != null);
  21. ISSUE: line 498 character 42: Use '!==' to compare with 'null'. - Evidence: add_plea = add_plea || (help_base != null);
  22. ISSUE: line 529 character 19: 'error' is already defined. - Evidence: var error = UFUI.getErrorMsg ('wpNoHelpTextError', true);
  23. ISSUE: line 626 character 11: Expected a 'break' statement before 'default'. - Evidence: }
  24. ISSUE: line 676 character 23: 'button_imgs' is already defined. - Evidence: var button_imgs = UFUI.getEntry ('wpUploadFormHelpOpenButton', 'uiElements', UFUI.internalLanguage);
  25. ISSUE: line 678 character 23: 'button_lk' is already defined. - Evidence: var button_lk = null;
  26. ISSUE: line 681 character 44: Use '===' to compare with '0'. - Evidence: if (!button_imgs || button_imgs.length == 0) {
  27. ISSUE: line 736 character 31: Use '!==' to compare with 'null'. - Evidence: if (current_dest_file != null) {
  28. ISSUE: line 760 character 32: 'current_dest_file' used out of scope. - Evidence: if (previous_file == current_dest_file) {
  29. ISSUE: line 769 character 47: Use '!==' to compare with 'null'. - Evidence: if (document.getElementById ('wpLicense') != null)
  30. ISSUE: line 782 character 44: Use '!==' to compare with 'null'. - Evidence: if (UploadForm.previous_hotcat_state != null && typeof (hotcat_set_state) == 'function') {
  31. ISSUE: line 784 character 19: Use '!==' to compare with 'null'. - Evidence: if (input != null) hotcat_cancel ();
  32. ISSUE: line 792 character 53: Bad or unnecessary escaping. - Evidence: if (desc && desc.value && desc.value.indexOf ('\{\{Information') >= 0) {
  33. ISSUE: line 792 character 55: Bad or unnecessary escaping. - Evidence: if (desc && desc.value && desc.value.indexOf ('\{\{Information') >= 0) {
  34. ISSUE: line 808 character 23: Use '!==' to compare with 'null'. - Evidence: if (target_name != null && target_name.value != null) // Strip whitespace
  35. ISSUE: line 808 character 52: Use '!==' to compare with 'null'. - Evidence: if (target_name != null && target_name.value != null) // Strip whitespace
  36. ISSUE: line 812 character 26: Use '!==' to compare with 'null'. - Evidence: && target_name != null && target_name.value != null) {
  37. ISSUE: line 812 character 55: Use '!==' to compare with 'null'. - Evidence: && target_name != null && target_name.value != null) {
  38. ISSUE: line 816 character 21: Use '!==' to compare with 'null'. - Evidence: if (input != null) hotcat_closeform ();
  39. ISSUE: line 824 character 30: Use '!==' to compare with 'null'. - Evidence: + (hotcat_state != null ? '\t' + hotcat_state : '')
  40. ISSUE: line 861 character 32: Use '!==' to compare with 'null'. - Evidence: if (UploadForm.errorMsgs != null) delete UploadForm.errorMsgs;
  41. ISSUE: line 862 character 40: The array literal notation [] is preferable. - Evidence: UploadForm.errorMsgs = new Array ();
  42. ISSUE: line 872 character 34: Use '!==' to compare with 'null'. - Evidence: if (UploadForm.errorMsgs != null) delete UploadForm.errorMsgs;
  43. ISSUE: line 873 character 42: The array literal notation [] is preferable. - Evidence: UploadForm.errorMsgs = new Array ();
  44. ISSUE: line 883 character 22: Use '!==' to compare with 'null'. - Evidence: if (fields != null && fields.length == 4) {
  45. ISSUE: line 884 character 30: Use '===' to compare with 'null'. - Evidence: if ( fields[1] == null || fields[1].search (/\S/) < 0 // Author
  46. ISSUE: line 885 character 30: Use '===' to compare with 'null'. - Evidence: || fields[2] == null || fields[2].search (/\S/) < 0) // Source
  47. ISSUE: line 890 character 42: Use '!==' to compare with 'null'. - Evidence: if (UploadForm.errorMsgs != null)
  48. ISSUE: line 897 character 31: Use '===' to compare with 'null'. - Evidence: && (fields[3] == null || fields[3].search (/\S/) < 0)) // Description
  49. ISSUE: line 908 character 21: Use '===' to compare with 'null'. - Evidence: if (license == null || license.selectedIndex == 0) {
  50. ISSUE: line 908 character 54: Use '===' to compare with '0'. - Evidence: if (license == null || license.selectedIndex == 0) {
  51. ISSUE: line 912 character 30: Bad or unnecessary escaping. - Evidence: if (d.indexOf ('\{\{') < 0) {
  52. ISSUE: line 912 character 32: Bad or unnecessary escaping. - Evidence: if (d.indexOf ('\{\{') < 0) {
  53. ISSUE: line 917 character 42: Use '!==' to compare with 'null'. - Evidence: if (UploadForm.errorMsgs != null)
  54. ISSUE: line 928 character 25: Use '!==' to compare with 'null'. - Evidence: if (target_name != null) {
  55. ISSUE: line 951 character 22: Use '!==' to compare with 'null'. - Evidence: if (my_warning != null) my_warning.style.display = 'none';
  56. ISSUE: line 968 character 37: Use '===' to compare with 'null'. - Evidence: if (UploadFormFull.multi_inputs == null) {
  57. ISSUE: line 995 character 42: Use '===' to compare with 'null'. - Evidence: var new_row = content.insertRow (idx == null ? content.rows.length : idx);
  58. ISSUE: line 1007 character 21: Use '!==' to compare with 'null'. - Evidence: if (stored_form != null) {
  59. ISSUE: line 1010 character 20: Use '!==' to compare with 'null'. - Evidence: if (prev_val != null) textfield.value = prev_val;
  60. ISSUE: line 1011 character 20: Use '!==' to compare with 'null'. - Evidence: if (prev_idx != null) {
  61. ISSUE: line 1047 character 21: Use '!==' to compare with 'null'. - Evidence: if (stored_form != null) {
  62. ISSUE: line 1057 character 62: Use '===' to compare with '0'. - Evidence: && stored_form[curr].id.indexOf ('wpLangSel') == 0) {
  63. ISSUE: line 1060 character 88: Use '===' to compare with '0'. - Evidence: if (curr < stored_form.length && stored_form[curr].id.indexOf ('wpDescText') == 0)
  64. ISSUE: line 1069 character 20: 'i' is already defined. - Evidence: for (var i = 0; i < UploadForm_description_languages.length; i++) {
  65. ISSUE: line 1075 character 24: Use '!==' to compare with 'null'. - Evidence: if (userLang != null && userLang != UFUI.defaultLanguage)
  66. ISSUE: line 1080 character 24: Use '!==' to compare with 'null'. - Evidence: if (userLang != null && userLang != UFUI.defaultLanguage)
  67. ISSUE: line 1218 character 17: Use '===' to compare with 'null'. - Evidence: if (label == null) label = UFUI.getLabel (id + 'UploadLbl');
  68. ISSUE: line 1234 character 22: Use '!==' to compare with 'null'. - Evidence: if (prev_value != null) field.value = prev_value;
  69. ISSUE: line 1252 character 18: Use '===' to compare with '0'. - Evidence: if (height == 0)
  70. ISSUE: line 1276 character 17: Use '===' to compare with 'null'. - Evidence: if (boxes == null || boxes.length == 0 || previous_form == null) return;
  71. ISSUE: line 1276 character 41: Use '===' to compare with '0'. - Evidence: if (boxes == null || boxes.length == 0 || previous_form == null) return;
  72. ISSUE: line 1276 character 63: Use '===' to compare with 'null'. - Evidence: if (boxes == null || boxes.length == 0 || previous_form == null) return;
  73. ISSUE: line 1278 character 22: Use '!==' to compare with 'null'. - Evidence: if (boxes[i] != null) {
  74. ISSUE: line 1280 character 24: Use '!==' to compare with 'null'. - Evidence: if (prev_val != null) boxes[i].checked = prev_val;
  75. ISSUE: line 1304 character 29: Use '!==' to compare with 'null'. - Evidence: if (current_dest_file != null) current_dest_file = current_dest_file.value;
  76. ISSUE: line 1305 character 29: Use '!==' to compare with 'null'. - Evidence: if (current_dest_file != null && current_dest_file.length > 0) {
  77. ISSUE: line 1340 character 66: Use '===' to compare with '0'. - Evidence: if (typeof (LanguageHandler) == 'undefined' || previous_type == 0) {
  78. ISSUE: line 1369 character 17: Use '!==' to compare with 'null'. - Evidence: if (license != null) {
  79. ISSUE: line 1378 character 17: Use '!==' to compare with 'null'. - Evidence: if (license != null) {
  80. ISSUE: line 1380 character 16: Use '!==' to compare with 'null'. - Evidence: if (prev != null) {
  81. ISSUE: line 1392 character 15: Use '!==' to compare with 'null'. - Evidence: if (src != null && (src.value == null || src.value.length == 0)) {
  82. ISSUE: line 1392 character 37: Use '===' to compare with 'null'. - Evidence: if (src != null && (src.value == null || src.value.length == 0)) {
  83. ISSUE: line 1392 character 65: Use '===' to compare with '0'. - Evidence: if (src != null && (src.value == null || src.value.length == 0)) {
  84. ISSUE: line 1395 character 18: Use '!==' to compare with 'null'. - Evidence: if (author != null && (author.value == null || author.value.length == 0)) {
  85. ISSUE: line 1395 character 43: Use '===' to compare with 'null'. - Evidence: if (author != null && (author.value == null || author.value.length == 0)) {
  86. ISSUE: line 1395 character 74: Use '===' to compare with '0'. - Evidence: if (author != null && (author.value == null || author.value.length == 0)) {
  87. ISSUE: line 1401 character 18: Use '!==' to compare with 'null'. - Evidence: if (date != null && (date.value == null || date.value.length == 0)) {
  88. ISSUE: line 1401 character 41: Use '===' to compare with 'null'. - Evidence: if (date != null && (date.value == null || date.value.length == 0)) {
  89. ISSUE: line 1401 character 70: Use '===' to compare with '0'. - Evidence: if (date != null && (date.value == null || date.value.length == 0)) {
  90. ISSUE: line 1406 character 23: Use '!==' to compare with 'null'. - Evidence: if (previous_form != null) {
  91. ISSUE: line 1414 character 42: Use '!==' to compare with 'null'. - Evidence: if (UploadForm.previous_hotcat_state != null && typeof (hotcat_set_state) == 'function') {
  92. ISSUE: line 1416 character 17: Use '!==' to compare with 'null'. - Evidence: if (input != null) hotcat_cancel ();
  93. ISSUE: line 1425 character 37: Use '===' to compare with 'null'. - Evidence: if (UploadFormFull.multi_inputs == null) {
  94. ISSUE: line 1427 character 16: Use '!==' to compare with 'null'. - Evidence: if (desc != null && !desc.disabled) desc_text = UploadForm.clean (desc.value);
  95. ISSUE: line 1434 character 20: Use '!==' to compare with 'null'. - Evidence: if (text != null && text.length > 0) {
  96. ISSUE: line 1437 character 32: Use '!==' to compare with 'null'. - Evidence: if (!basic && lang != null && lang.length > 0 && lang != 'unknown') {
  97. ISSUE: line 1441 character 41: Bad or unnecessary escaping. - Evidence: desc_text = desc_text + '\{\{' + lang + '|1=' + text + '\}\}';
  98. ISSUE: line 1441 character 43: Bad or unnecessary escaping. - Evidence: desc_text = desc_text + '\{\{' + lang + '|1=' + text + '\}\}';
  99. ISSUE: line 1441 character 72: Bad or unnecessary escaping. - Evidence: desc_text = desc_text + '\{\{' + lang + '|1=' + text + '\}\}';
  100. ISSUE: line 1441 character 74: Bad or unnecessary escaping. - Evidence: desc_text = desc_text + '\{\{' + lang + '|1=' + text + '\}\}';
  101. ISSUE: line 1456 character 21: Bad or unnecessary escaping. - Evidence: desc_text = '\{\{Information\n'
  102. ISSUE: line 1456 character 23: Bad or unnecessary escaping. - Evidence: desc_text = '\{\{Information\n'
  103. ISSUE: line 1461 character 64: Use '!==' to compare with 'null'. - Evidence: + ((other && !other.disabled && other.value != null)
  104. ISSUE: line 1464 character 76: Use '!==' to compare with 'null'. - Evidence: + ((othervers && !othervers.disabled && othervers.value != null)
  105. ISSUE: line 1467 character 24: Bad or unnecessary escaping. - Evidence: + '\}\}\n';
  106. ISSUE: line 1467 character 26: Bad or unnecessary escaping. - Evidence: + '\}\}\n';
  107. ISSUE: line 1488 character 21: Use '!==' to compare with 'null'. - Evidence: if (target_name != null && target_name.value != null) // Strip whitespace
  108. ISSUE: line 1488 character 50: Use '!==' to compare with 'null'. - Evidence: if (target_name != null && target_name.value != null) // Strip whitespace
  109. ISSUE: line 1494 character 20: Use '!==' to compare with 'null'. - Evidence: if (dummy_desc != null) dummy_desc.parentNode.removeChild (dummy_desc);
  110. ISSUE: line 1497 character 24: Use '!==' to compare with 'null'. - Evidence: && target_name != null && target_name.value != null) {
  111. ISSUE: line 1497 character 53: Use '!==' to compare with 'null'. - Evidence: && target_name != null && target_name.value != null) {
  112. ISSUE: line 1501 character 19: Use '!==' to compare with 'null'. - Evidence: if (input != null) hotcat_closeform ();
  113. ISSUE: line 1512 character 28: Use '!==' to compare with 'null'. - Evidence: + (hotcat_state != null ? '\t' + hotcat_state : '')
  114. ISSUE: line 1559 character 32: Use '!==' to compare with 'null'. - Evidence: if (UploadForm.errorMsgs != null) delete UploadForm.errorMsgs;
  115. ISSUE: line 1560 character 40: The array literal notation [] is preferable. - Evidence: UploadForm.errorMsgs = new Array ();
  116. ISSUE: line 1584 character 39: Use '===' to compare with 'null'. - Evidence: if (UploadFormFull.multi_inputs == null) {
  117. ISSUE: line 1586 character 18: Use '!==' to compare with 'null'. - Evidence: if (desc != null) all_descs = desc.value;
  118. ISSUE: line 1594 character 42: Use '===' to compare with 'null'. - Evidence: var license_chosen = license_field == null || license_field.selectedIndex > 0;
  119. ISSUE: line 1603 character 23: Use '!==' to compare with 'null'. - Evidence: if (target_name != null) {
  120. ISSUE: line 1620 character 43: Use '===' to compare with 'null'. - Evidence: if (UploadFormFull.multi_inputs == null) {
  121. ISSUE: line 1621 character 22: 'desc' is already defined. - Evidence: var desc = document.getElementById ('wpDesc');
  122. ISSUE: line 1622 character 22: Use '!==' to compare with 'null'. - Evidence: if (desc != null) {
  123. ISSUE: line 1640 character 22: Use '!==' to compare with 'null'. - Evidence: if (my_warning != null) my_warning.style.display = 'none';
  124. ISSUE: line 1647 character 37: Use '===' to compare with 'null'. - Evidence: if (UploadFormFull.multi_inputs == null) return;
  125. ISSUE: line 1681 character 27: Use '!==' to compare with 'null'. - Evidence: if (hotcat_label_cell != null) {
  126. ISSUE: line 1714 character 28: Use '===' to compare with '0'. - Evidence: if (!id || id.length == 0) id = elems[i].name;
  127. ISSUE: line 1717 character 36: Confusing use of '!'. - Evidence: if (elems[i].disabled != !enabled) {
  128. ISSUE: line 1739 character 22: Use '!==' to compare with 'null'. - Evidence: if (my_warning != null) my_warning.style.display = 'none';
  129. ISSUE: line 1748 character 24: Use '===' to compare with 'null'. - Evidence: if ( stored_form == null || stored_form.length <= 1
  130. ISSUE: line 1749 character 23: Use '===' to compare with 'null'. - Evidence: || element_id == null || element_id.length == 0)
  131. ISSUE: line 1749 character 52: Use '===' to compare with '0'. - Evidence: || element_id == null || element_id.length == 0)
  132. ISSUE: line 1752 character 26: Use '!==' to compare with 'null'. - Evidence: if (stored_form[i] != null && element_id == stored_form[i].id)
  133. ISSUE: line 1821 character 29: Use '===' to compare with 'null'. - Evidence: if (preview_panel == null) return;
  134. ISSUE: line 1827 character 42: Use '===' to compare with '0'. - Evidence: if (!preview || preview.length == 0 || preview == ' ') {
  135. ISSUE: line 1856 character 17: Use '===' to compare with 'null'. - Evidence: if (request == null) return;
  136. ISSUE: line 1860 character 22: Use '===' to compare with 'null'. - Evidence: if (uploadButton == null) return;
  137. ISSUE: line 1903 character 16: Bad or unnecessary escaping. - Evidence: return '\[\[User:' + mw.config.get('wgUserName') + '|' + mw.config.get('wgUserName') + '\]\]';
  138. ISSUE: line 1903 character 18: Bad or unnecessary escaping. - Evidence: return '\[\[User:' + mw.config.get('wgUserName') + '|' + mw.config.get('wgUserName') + '\]\]';
  139. ISSUE: line 1903 character 96: Bad or unnecessary escaping. - Evidence: return '\[\[User:' + mw.config.get('wgUserName') + '|' + mw.config.get('wgUserName') + '\]\]';
  140. ISSUE: line 1903 character 98: Bad or unnecessary escaping. - Evidence: return '\[\[User:' + mw.config.get('wgUserName') + '|' + mw.config.get('wgUserName') + '\]\]';
  141. ISSUE: line 1931 character 17: Use '===' to compare with '0'. - Evidence: if (idx == 0) span = container;
  142. ISSUE: line 1945 character 28: 'default_text' is already defined. - Evidence: var default_text = UFUI.getLabel (default_id, true);
  143. ISSUE: line 1961 character 30: Use '===' to compare with '0'. - Evidence: if (!imgs || imgs.length == 0 || typeof (Buttons) == 'undefined') {
  144. ISSUE: line 1963 character 22: 'buttonText' is already defined. - Evidence: var buttonText = getButtonSpan (button, 0);
  145. ISSUE: line 2072 character 38: Use '!==' to compare with 'null'. - Evidence: (original_desc.defaultValue != null && original_desc.defaultValue.length > 0)
  146. ISSUE: line 2073 character 31: Missing semicolon. - Evidence: || UploadForm.isReupload
  147. ISSUE: line 2097 character 20: Use '===' to compare with 'null'. - Evidence: if (my_warning == null) {
  148. ISSUE: line 2136 character 31: Use '!==' to compare with 'null'. - Evidence: if (my_warning.firstChild != null)
  149. ISSUE: line 2146 character 32: Use '!==' to compare with 'null'. - Evidence: if (UploadForm.oldOnSubmit != null) {
  150. ISSUE: line 2148 character 21: eval can be harmful. - Evidence: do_submit = eval (UploadForm.oldOnSubmit);
  151. ISSUE: line 2148 character 21: Too many errors. (75% scanned). - Evidence: undefined
Retrieved from "https://commons.wikimedia.org/w/index.php?title=Commons:User_scripts/reports/MediaWiki:UploadFormTest.js&oldid=531036607"