Commons:User scripts/reports/MediaWiki:Commander.js

This is the report page for MediaWiki:Commander.js. It is bot-maintained. All manual changes might be overwritten.

jshint

1. ISSUE: line 155 character 28: Use '===' to compare with ''. - Evidence: if ( thumbs.length == '' ) thumbs = $(baseid+' .cc_thumb_selected') ;
2. ISSUE: line 184 character 24: Use '===' to compare with '0'. - Evidence: if ( tr.length == 0 ) return ;
3. ISSUE: line 192 character 56: Use '===' to compare with '0'. - Evidence: if ( $('#'+did+' .cc_cmsd_row').length == 0 ) $('#'+did).dialog("close") ;
4. ISSUE: line 195 character 21: 'col' is already defined. - Evidence: var col = '#FFFF84' ;
5. ISSUE: line 198 character 21: 'col' is already defined. - Evidence: var col = 'red' ;
6. ISSUE: line 204 character 49: Use '!==' to compare with ''. - Evidence: if ( typeof text != 'undefined' && text != '' ) td.next().append('<br/><i>'+text+'</i>');
7. ISSUE: line 233 character 37: Use '!==' to compare with ''. - Evidence: if ( !do_copy && oldcat != '' ) {
8. ISSUE: line 239 character 22: Use '!==' to compare with ''. - Evidence: if ( cat != '' ) {
9. ISSUE: line 272 character 75: Missing semicolon. - Evidence: $.each ( data2.query.pages , function ( k2 , v2 ) { d = v2 } ) ;
10. ISSUE: line 281 character 29: Use '!==' to compare with ''. - Evidence: if ( oldcat != '' ) sum.push ( 'removing [[Category:'+oldcat.ucFirst()+']]' ) ;
11. ISSUE: line 282 character 26: Use '!==' to compare with ''. - Evidence: if ( cat != '' ) sum.push ( 'adding [[Category:'+cat.ucFirst()+']]' ) ;
12. ISSUE: line 308 character 23: Use '===' to compare with '0'. - Evidence: if ( o.length == 0 ) {
13. ISSUE: line 316 character 66: Use '!==' to compare with '0'. - Evidence: } else if ( do_copy || commander.panes[source_pane].mode != 0 ) { // Copy
14. ISSUE: line 369 character 41: Use '!==' to compare with '0'. - Evidence: if ( commander.panes[pane].mode != 0 ) return ;
15. ISSUE: line 422 character 37: Missing '()' invoking a constructor. - Evidence: commander.panes[pane] = new Object ;
16. ISSUE: line 425 character 43: Missing '()' invoking a constructor. - Evidence: commander.panes[pane].modes = new Object ;
17. ISSUE: line 427 character 50: Missing '()' invoking a constructor. - Evidence: commander.panes[pane].modes[k] = new Object ;
18. ISSUE: line 428 character 56: Missing '()' invoking a constructor. - Evidence: commander.panes[pane].modes[k].files = new Object ;
19. ISSUE: line 542 character 62: Use '===' to compare with ''. - Evidence: if ( commander.panes[pane].modes[0].category == '' ) return ; // No drop on blank category
20. ISSUE: line 552 character 62: Use '===' to compare with ''. - Evidence: if ( commander.panes[pane].modes[0].category == '' ) return ; // No drop on blank category
21. ISSUE: line 559 character 62: Use '===' to compare with ''. - Evidence: if ( commander.panes[pane].modes[0].category == '' ) return ; // No drop on blank category
22. ISSUE: line 566 character 62: Use '===' to compare with ''. - Evidence: if ( commander.panes[pane].modes[0].category == '' ) return ; // No drop on blank category
23. ISSUE: line 606 character 18: Use '===' to compare with ''. - Evidence: if ( cat == '' ) return ;
24. ISSUE: line 608 character 52: Missing '()' invoking a constructor. - Evidence: commander.panes[pane].modes[0].files = new Object ;
25. ISSUE: line 629 character 67: Missing semicolon. - Evidence: $.each ( data.query.pages , function ( k , v ) { d = v } ) ;
26. ISSUE: line 647 character 67: Missing semicolon. - Evidence: $.each ( data.query.pages , function ( k , v ) { d = v } ) ;
27. ISSUE: line 656 character 20: Use '!==' to compare with ''. - Evidence: if ( h != '' ) $('#cc_cat_sidebar'+pane+' .cc_parentcats').html ( '<table class="cc_catlink">' + h + '</table>' ) ;
28. ISSUE: line 668 character 20: Use '!==' to compare with ''. - Evidence: if ( h != '' ) $('#cc_cat_sidebar'+pane+' .cc_subcats').html ( '<table class="cc_catlink">' + h + '</table>' ) ;
29. ISSUE: line 714 character 52: Missing '()' invoking a constructor. - Evidence: commander.panes[pane].modes[1].files = new Object ;
30. ISSUE: line 753 character 18: Use '===' to compare with '0'. - Evidence: if ( cnt == 0 ) return ;
31. ISSUE: line 754 character 44: Use '===' to compare with '0'. - Evidence: if ( commander.panes[pane].loading == 0 && cnt > 0 ) $('#cc_loading'+pane).show() ;
32. ISSUE: line 894 character 19: Use '===' to compare with '0'. - Evidence: if ( mode == 0 ) f = f.sort ( commander.sortByNameAsc ) ;
33. ISSUE: line 898 character 35: Use '===' to compare with ''. - Evidence: var was_blank = op.html() == '' ;
34. ISSUE: line 933 character 38: Use '===' to compare with 'null'. - Evidence: if ( newfile == null ) return ; // Canceled
35. ISSUE: line 960 character 19: Use '===' to compare with '0'. - Evidence: if ( mode == 0 ) {
36. ISSUE: line 987 character 21: 'cat' is already defined. - Evidence: var cat = '' ;
37. ISSUE: line 988 character 23: Use '===' to compare with '0'. - Evidence: if ( mode == 0 ) {
38. ISSUE: line 989 character 25: 'cat' is already defined. - Evidence: var cat = commander.panes[pane].modes[mode].category ;
39. ISSUE: line 1000 character 31: Missing '()' invoking a constructor. - Evidence: var obj = new Object ;
40. ISSUE: line 1036 character 70: Missing semicolon. - Evidence: $.each ( data.query.pages , function ( k2 , v2 ) { d = v2 } ) ;
41. ISSUE: line 1084 character 17: Implied eval. Consider passing a function instead of a string. - Evidence: setTimeout ( "commander.updateSelectionStatus();" , 10 ) ;
42. ISSUE: line 1088 character 49: Use '!==' to compare with '0'. - Evidence: if ( commander.panes[pane].mode != 0 ) do_copy = true ; // All except categories MUST copy!
43. ISSUE: line 1108 character 28: Use '===' to compare with '0'. - Evidence: var vpad = padsize == 0 ? '' : '<div style="height:' + padsize + 'px"></div>' ;
44. ISSUE: line 1123 character 24: Use '===' to compare with 'false'. - Evidence: if ( thumb_url == false ) thumb_url = '//upload.wikimedia.org/wikipedia/commons/thumb/4/47/Sound-icon.svg/'+commander.thumb_max+'px-Sound-icon.svg.png' ;
45. ISSUE: line 1212 character 21: 'url' is already defined. - Evidence: var url = mw.config.get('wgServer') + wgScriptPath + "/index.php?title=Special:Commander&pane1=cat&cat1=" + encodeURI(mw.config.get('wgTitle')) + "&run1=1&pane2=cat" ;