Template talk:Assessments

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

Template edit for POTY finalists/winners files

[edit]

{{Edit request}}

A proposal was made to edit the template in order to also add a top icon to files that were assessed POTY finalist or winner This file was awarded first place in Picture of the Year This file was awarded second place in Picture of the Year This file was awarded third place in Picture of the Year This file was a finalist in Picture of the Year.

The proposal can be accessed by this link.

It has now been one month that the proposal was made and there has been a clear consensus (and even unanimity with 11 people in favor and 0 against) to implement the proposal in this template.

I am therefore placing the {{Edit request}} template on this page in order to proceed to the implementation of the proposal.

I made a draft of the code to implement this that can be accessed on this page (it is only the top of the code, the bottom stays of course identical). Unfortunately I can't test it so it is possible that the code might need some adjustment/correction in case it doesn't work. I thank you in advance for resolving it if it is needed.

Pinging the last person that proceeded to the edit of the template : TKsdik8900 but anyone that has access to edit this template can feel free to do it.

Thank you in advance and wishing you a nice day!

Best regards, -- Giles Laurent (talk) 17:09, 19 June 2024 (UTC)[reply]

✓ Done in Special:Diff/885668761. I have checked several pages with {{Assessments}} specifying the POTY parameter, and it seems to be working well. From my perspective, the description phrase "This file was awarded first place in Picture of the Year yyyy" should be internationalized as well as FP, QI and other collections by editing {{Top icon hover i18n}}. Thank you for your contributions. --TKsdik8900 (talk) 09:07, 20 June 2024 (UTC)[reply]
Thank you for the edit! I'm very happy the code worked directly! I agree with the translation. Anyone that has the skills to do it, please feel free to do so! -- Giles Laurent (talk) 10:38, 20 June 2024 (UTC)[reply]

POTD topicon

[edit]

{{Editrequest}} Template does not show the POTD topicon when POTD parameters are filled Examples:

The template code should be added after VI, but preferably between FP and QI:

{{#if:{{{POTD|}}}|{{Top icon
| imagename    = Potd-logo.svg
| imagesize    = 64px
| wikilink     = Commons:Picture of the day
| description   = {{Top icon hover i18n|picture of the day}}
}}}}

I have tested the code multiple times and all runs worked (I hope). Thanks! Zzzs (talk) 17:13, 21 June 2024 (UTC)[reply]

I don’t understand this edit request… can you describe the expected change? I don’t notice any difference when I add this code and preview File:Waldbillig (LU), Schiessentümpel -- 2015 -- 6033.jpg with it vs. without – I see “picture of the day” both in what I assume are the top icons (top right corner, same line as the file title) and in the “Assessment” section. Lucas Werkmeister (talk) 19:32, 23 June 2024 (UTC)[reply]
@Lucas Werkmeister I believe Template:Picture of the day is the reason for the topicon's appearance. Try removing it before testing again. I hope this helps. Zzzs (talk) 20:18, 23 June 2024 (UTC)[reply]
Actually, this is a better example. Zzzs (talk) 22:16, 23 June 2024 (UTC)[reply]
Thanks, that helps – I didn’t really want to break an existing file (especially not a featured picture) just to test an edit request. ✓ Done. --Lucas Werkmeister (talk) 17:31, 26 June 2024 (UTC)[reply]